Skip to content

Conversation

@tobil4sk
Copy link
Member

@tobil4sk tobil4sk commented Dec 20, 2025

On systems where char is unsigned, this function does not behave correctly, as (char)255 is equal to -1, so hl_dyni32(255) returns -1.

@Simn Simn merged commit d9a3270 into HaxeFoundation:master Dec 20, 2025
13 checks passed
@Simn
Copy link
Member

Simn commented Dec 20, 2025

TIL that char isn't signed by default, unlike int.

@tobil4sk tobil4sk deleted the fix/hl_dyni32-signed-char branch December 20, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants