[lua] Fix redundant _hx_funcToField for non-function fields #12485
+23
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes HaxeFoundation#11842. The OpAssign patterns in genlua.ml were wrapping all field assignments between anonymous/closure types with _hx_funcToField, regardless of whether the field was actually a function type. Added is_function_type checks to the three patterns that were missing them, matching the existing pattern for TLocal assignments. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11842. The OpAssign patterns in genlua.ml were wrapping all field assignments between anonymous/closure types with _hx_funcToField, regardless of whether the field was actually a function type.
Added is_function_type checks to the three patterns that were missing them, matching the existing pattern for TLocal assignments.