[lua] Fix redundant _hx_funcToField for non-function fields #12486
+23
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11842. Non-function fields were being unnecessarily wrapped with
_hx_funcToFieldduring assignment.Problem
When assigning fields between anonymous types (typedefs), the Lua generator wrapped all assignments with
_hx_funcToField, even for non-function types likeInt:Fix
Added
is_function_type e2.etypeguards to three patterns ingenlua.mlthat were missing them. The fourth pattern (forTLocalassignments) already had this check.Test plan
testNoFuncToFieldForNonFunctionsinTestLua.hx