Skip to content

Misc tests cleanup#12759

Merged
Simn merged 7 commits intodevelopmentfrom
misc-tests-cleanup
Mar 7, 2026
Merged

Misc tests cleanup#12759
Simn merged 7 commits intodevelopmentfrom
misc-tests-cleanup

Conversation

@Simn
Copy link
Member

@Simn Simn commented Mar 7, 2026

Our misc tests are a huge mess, so let's try to clean that up.

The directory structure should be like this for all targets:

misc
    eval
        projects
        other-target-specific-tests

The projects directory remains the one that is auto-explored by the runner. To that end, the runner now changes its cwd to its first CLI argument, so we can do --run Main eval to run the eval tests.

I've also moved the toplevel projects directory to eval/projects and updated the CI references to it. Here's what we need to do now:

  1. Also add a "cross" directory for tests that are run on multiple targets, following the same structure as above.
  2. Delete all the current target/run.hxml we no longer need.
  3. Go through the non-target sub-directories in tests/misc and move them to where they should be by inspecting what their HXMLs run.
  4. Update all references in tests/runci accordingly.
  5. Go through all projects in eval/projects and move the ones that are actually running other targets.
  6. Update all references in tests/runci accordingly.
  7. Test if it works and make adjustments until it does.

@Simn
Copy link
Member Author

Simn commented Mar 7, 2026

@copilot There's your mission! I recommend making the first commit after step 4 and another one after step 6. Note that CI is currently already broken for eval and JS (and maybe others that haven't run yet), which may or may not be addressed by the changes here.

Copy link
Contributor

Copilot AI commented Mar 7, 2026

@Simn I've opened a new pull request, #12760, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* Steps 1-4: Create cross dir, delete old run.hxml files, move non-target dirs, update runci refs

Co-authored-by: Simn <634365+Simn@users.noreply.github.com>

* Steps 5-6: Move eval/projects that run other targets to correct target dirs

Co-authored-by: Simn <634365+Simn@users.noreply.github.com>

* Fix missing .haxelib for Issue11700, update Issue11280 expected output, fix server test paths

Co-authored-by: Simn <634365+Simn@users.noreply.github.com>

* Remove accidentally committed .n build artifacts

Co-authored-by: Simn <634365+Simn@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Simn <634365+Simn@users.noreply.github.com>
@Simn Simn marked this pull request as ready for review March 7, 2026 10:07
@Simn Simn merged commit e876575 into development Mar 7, 2026
147 of 148 checks passed
@Simn Simn deleted the misc-tests-cleanup branch March 7, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants