Merged
Conversation
Member
Author
|
@copilot There's your mission! I recommend making the first commit after step 4 and another one after step 6. Note that CI is currently already broken for eval and JS (and maybe others that haven't run yet), which may or may not be addressed by the changes here. |
Contributor
* Initial plan * Steps 1-4: Create cross dir, delete old run.hxml files, move non-target dirs, update runci refs Co-authored-by: Simn <634365+Simn@users.noreply.github.com> * Steps 5-6: Move eval/projects that run other targets to correct target dirs Co-authored-by: Simn <634365+Simn@users.noreply.github.com> * Fix missing .haxelib for Issue11700, update Issue11280 expected output, fix server test paths Co-authored-by: Simn <634365+Simn@users.noreply.github.com> * Remove accidentally committed .n build artifacts Co-authored-by: Simn <634365+Simn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Simn <634365+Simn@users.noreply.github.com>
tobil4sk
reviewed
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our misc tests are a huge mess, so let's try to clean that up.
The directory structure should be like this for all targets:
The projects directory remains the one that is auto-explored by the runner. To that end, the runner now changes its cwd to its first CLI argument, so we can do
--run Main evalto run the eval tests.I've also moved the toplevel projects directory to eval/projects and updated the CI references to it. Here's what we need to do now: