Skip to content

fixes multithread marking #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hughsando merged 1 commit into from
Jul 10, 2025
Merged

fixes multithread marking #1240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/hx/gc/Immix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,15 +198,13 @@ static bool sGcVerifyGenerational = false;
#else
enum { MAX_GC_THREADS = 2 };
#endif

// You can uncomment this for better call stacks if it crashes while collecting
#define HX_MULTI_THREAD_MARKING
#else
enum { MAX_GC_THREADS = 1 };
#endif

#if (MAX_GC_THREADS>1)
// You can uncomment this for better call stacks if it crashes while collecting
#define HX_MULTI_THREAD_MARKING
#endif

#ifdef PROFILE_THREAD_USAGE
static int sThreadMarkCountData[MAX_GC_THREADS+1];
static int sThreadArrayMarkCountData[MAX_GC_THREADS+1];
Expand Down Expand Up @@ -1952,7 +1950,7 @@ class MarkContext
if (obj)
{
obj->__Mark(this);
#if HX_MULTI_THREAD_MARKING
#ifdef HX_MULTI_THREAD_MARKING
// Load balance
if (sLazyThreads && marking->count>32)
{
Expand Down