[cppia] Fix int overflow in arithmetic assignments #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Member
|
Please resolve the conflict! |
tobil4sk
force-pushed
the
fix/cppia-int-mult-assign-overflow
branch
from
50fdfb6 to
98d6a1b
Compare
Currently, the cppia interp runtime uses float operations for arithmetic assignments such as *=. This results in inconsistent int overflow behaviour.
tobil4sk
force-pushed
the
fix/cppia-int-mult-assign-overflow
branch
from
98d6a1b to
54ced66
Compare
Member
Author
|
Conflict resolved and ci is finally green as well! |
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the cppia interp runtime uses float operations for arithmetic assignments such as *=. This results in inconsistent int overflow behaviour.
Closes #1257