Skip to content

Fix ranlib when libdir is set. #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Simn merged 4 commits into from
Nov 25, 2025
Merged

Fix ranlib when libdir is set. #1267

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ec6401
Fix `ranlib` when `libdir` is set.
MAJigsaw77 Nov 5, 2025
d87ca72
Dont add the `out`.
MAJigsaw77 Nov 5, 2025
3567d9b
Consistent lib name + add a log when the file is moved.
MAJigsaw77 Nov 5, 2025
bb8c9c2
Put the log before moving.
MAJigsaw77 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/hxcpp/Linker.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ class Linker

if (mRanLib!="")
{
args = [out_name];
args = [mLibDir!=""?mLibDir+"/"+file_name:out_name];
var result = ProcessManager.runCommand("", mRanLib, args, true, true, false, "\x1b[1mRanlib:\x1b[0m " + out_name);
Copy link
Member

@tobil4sk tobil4sk Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would also make sense to change out_name here for consistency, same for line 295

if (result!=0)
{
Expand Down
Loading