-
Notifications
You must be signed in to change notification settings - Fork 2
Change shapes image #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/HealthBioscienceIDEAS/microscopy-novice/compare/md-outputs..md-outputs-PR-99 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-11-21 07:30:27 +0000 |
K-Meech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stellaprins - this looks great! I agree this change makes the differences between the thresholding methods clearer + the otsu explanation less confusing.
I've put a couple of very minor comments below:
Co-authored-by: Kimberly Meechan <[email protected]>
K-Meech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stellaprins - looking great!
Could you possibly put the mask images into a grid (e.g. around 2 per line), rather than all in one line? Now there are 5, they end up quite small in the final rendered site, so it's a bit hard to see the differences. No worries if this is hard to change!
|
Yes, good call! What do you think of 3 per line (and including the original) as I've done now? Happy to change it to 2 per line :) |
K-Meech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stellaprins - really like the new grid layout! Much easier to see the images 😄
I noticed one final part that needs to be updated in the text (the order of the peaks in the first exercise), but otherwise this is ready to merge.
K-Meech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stellaprins - I'll merge this now 🎉
Auto-generated via `{sandpaper}`
Source : ec1da21
Branch : main
Author : Kimberly Meechan <[email protected]>
Time : 2025-11-21 09:10:04 +0000
Message : Merge pull request #99 from stellaprins/sp/otsu
Change shapes image
Auto-generated via `{sandpaper}`
Source : 1439450
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-11-21 09:10:54 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : ec1da21
Branch : main
Author : Kimberly Meechan <[email protected]>
Time : 2025-11-21 09:10:04 +0000
Message : Merge pull request #99 from stellaprins/sp/otsu
Change shapes image
Auto-generated via `{sandpaper}`
Source : 1439450
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-11-21 09:10:54 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : ec1da21
Branch : main
Author : Kimberly Meechan <[email protected]>
Time : 2025-11-21 09:10:04 +0000
Message : Merge pull request #99 from stellaprins/sp/otsu
Change shapes image
Auto-generated via `{sandpaper}`
Source : 1439450
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-11-21 09:10:54 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : ec1da21
Branch : main
Author : Kimberly Meechan <[email protected]>
Time : 2025-11-21 09:10:04 +0000
Message : Merge pull request #99 from stellaprins/sp/otsu
Change shapes image
Auto-generated via `{sandpaper}`
Source : 1439450
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-11-21 09:10:54 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : ec1da21
Branch : main
Author : Kimberly Meechan <[email protected]>
Time : 2025-11-21 09:10:04 +0000
Message : Merge pull request #99 from stellaprins/sp/otsu
Change shapes image
Auto-generated via `{sandpaper}`
Source : 1439450
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-11-21 09:10:54 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : ec1da21
Branch : main
Author : Kimberly Meechan <[email protected]>
Time : 2025-11-21 09:10:04 +0000
Message : Merge pull request #99 from stellaprins/sp/otsu
Change shapes image
Auto-generated via `{sandpaper}`
Source : 1439450
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-11-21 09:10:54 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : ec1da21
Branch : main
Author : Kimberly Meechan <[email protected]>
Time : 2025-11-21 09:10:04 +0000
Message : Merge pull request #99 from stellaprins/sp/otsu
Change shapes image
Auto-generated via `{sandpaper}`
Source : 1439450
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-11-21 09:10:54 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : ec1da21
Branch : main
Author : Kimberly Meechan <[email protected]>
Time : 2025-11-21 09:10:04 +0000
Message : Merge pull request #99 from stellaprins/sp/otsu
Change shapes image
Auto-generated via `{sandpaper}`
Source : 1439450
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-11-21 09:10:54 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : ec1da21
Branch : main
Author : Kimberly Meechan <[email protected]>
Time : 2025-11-21 09:10:04 +0000
Message : Merge pull request #99 from stellaprins/sp/otsu
Change shapes image
Auto-generated via `{sandpaper}`
Source : 1439450
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-11-21 09:10:54 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : ec1da21
Branch : main
Author : Kimberly Meechan <[email protected]>
Time : 2025-11-21 09:10:04 +0000
Message : Merge pull request #99 from stellaprins/sp/otsu
Change shapes image
Auto-generated via `{sandpaper}`
Source : 1439450
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2025-11-21 09:10:54 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : ec1da21
Branch : main
Author : Kimberly Meechan <[email protected]>
Time : 2025-11-21 09:10:04 +0000
Message : Merge pull request #99 from stellaprins/sp/otsu
Change shapes image
Why is this PR needed?
A demonstration of the Otsu thresholding method not performing robustely on images that do not have bimodal distributions of pixel values would make more sense given the context of the lesson material.
What does this PR do?
onlymost suitable for images that show two clear peaks in their histogram (also known as a ‘bimodal’ histogram"Previous mask created by Otsu thresholding
New mask created by Otsu thresholding
New figure mask panels with thresholding labels
Linked issues
Resolves #98
How was this PR tested?
I built and checked the documentation locally and checked whether it looked like I expected.