Skip to content

Comments

Feature/rsp 5036 5051 non rev document tab#168

Open
Chris-McNeill-PA-HRA wants to merge 3 commits intomainfrom
feature/rsp-5036-5051-non-rev-document-tab
Open

Feature/rsp 5036 5051 non rev document tab#168
Chris-McNeill-PA-HRA wants to merge 3 commits intomainfrom
feature/rsp-5036-5051-non-rev-document-tab

Conversation

@Chris-McNeill-PA-HRA
Copy link
Collaborator

What was the purpose of this ticket?

As a Backstage user
I want to view non-reviewable modifications

Jira Ref

RSP-5036
RSP-5051

Type of Change

Put [X] inside the [] to make the box ticked

  • New Tests
  • Updating Tests
  • [] Fixing Tests
  • [] Framework Improvements
  • [] Documentation

Solution

What work was completed to cover off the story?

  • Adjusted step to cover both reviewable and non-reviewable view
  • Added scenario re-using reviewable scenario with a team 1 non-reviewable input
  • Removed old feature file and steps related to obsolete system test
  • Updated confirmation page common header due to recent changes

Checklist

Put [X] inside the [] to make the box ticked

  • Your code builds clean without any warnings, i.e. no ESLint or SonarCube errors
  • You have run the Pipeline jobs against this branch successfully
  • Any new or updated tests add value, i.e. provide correct assurances, fail when expected and log errors appropriately
  • Tests have been tagged appropriately
  • No duplicate tests, steps or functions have been added
  • You are using the correct naming conventions
  • Added files have been placed correctly within the projects folder structure
  • There is no dead code e.g. no "TODO" comments left, no unused imports etc
  • Any Framework updates have been explained and demonstrated to the team

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant