Skip to content

fix: cannot download card image URL for battleground trinkets #4623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gweesin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: cannot download card image URL for battleground trinkets #4623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions Hearthstone Deck Tracker/Utility/Assets/AssetDownloaders.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
using System;
using System.IO;
using System.Windows.Media.Imaging;
using HearthDb.Enums;

namespace Hearthstone_Deck_Tracker.Utility.Assets
{
Expand Down Expand Up @@ -58,9 +59,18 @@ static AssetDownloaders()
{
cardImageDownloader = new AssetDownloader<Hearthstone.Card, BitmapImage>(
Path.Combine(Config.AppDataPath, "Images", "CardImages"),
card => $"https://art.hearthstonejson.com/v1/{(card.BaconCard ? "bgs" : "render")}/latest" +
$"/{Helper.GetCardLanguage()}/{(Config.Instance.HighResolutionCardImages ? "512x" : "256x")}" +
$"/{card.Id}{(card.BaconTriple ? "_triple" : "")}.png",
card =>
{

var quality = Config.Instance.HighResolutionCardImages ? "512x" : "256x";
if(CardType.BATTLEGROUND_TRINKET.Equals(card.Type))
{
quality = "orig";
}

return
$"https://art.hearthstonejson.com/v1/{(card.BaconCard ? "bgs" : "render")}/latest/{Helper.GetCardLanguage()}/{quality}/{card.Id}{(card.BaconTriple ? "_triple" : "")}.png";
},
card => $"{card.Id}{(card.BaconTriple ? "_triple" : "")}.png",
Helper.BitmapImageFromBytes,
maxCacheSize: 200,
Expand Down