Update all OpenGL examples to RGFW 1.80-dev #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while (!RGFW_window_shouldClose(win) && running) | ||
| { | ||
| /* Input */ | ||
| RGFW_window_checkEvents(win, RGFW_eventNoWait); |
Member
There was a problem hiding this comment.
Should be checked to pollEvents, don't use checkEvent if you don't need the event queue.
Comment on lines
231
to
240
| NK_API double | ||
| nk_RGFW_get_time() { | ||
| static time_t start = 0; | ||
| if (start == 0) { | ||
| start = time(0); | ||
| } | ||
|
|
||
| return difftime(time(0),start); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Probably better to use clock or something. Time is per second.
Also what is diff time? Just time - time should work.
Contributor
Author
There was a problem hiding this comment.
Diff time is the difference in time between the two arguments
Member
|
Needs to be updated to newest version. Probably better to wait for RGFW 1.8.0 to be released. |
Contributor
Author
|
updated time function due to it being imprecise |
Member
|
Clock isn't standard across all OSes, see https://github.com/ColleagueRiley/rtime/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as title
this doesn't include rgfw_rawfb, yet i play on doing that soon