Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| result | ||
| } else { | ||
| Ok(()) |
There was a problem hiding this comment.
Bug: Health Checks Fail Due to DashMap Race Condition
A race condition in the health monitoring loop, introduced by the DashMap migration, can cause health checks to be silently skipped or misapplied. The loop iterates over DashMap entries to collect router IDs, then attempts to retrieve and check the corresponding monitor via get_mut() within an async future. If an entry is removed or replaced between iteration and get_mut(), the health check is silently skipped (returning Ok(())) or the wrong monitor is checked. This bypasses the concurrency control of the previous RwLock implementation, potentially leading to unmonitored failed providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.