fix(gateway): preserve Responses tool linkage and structured output format#5624
Draft
ohnoah wants to merge 1 commit intoHelicone:mainfrom
Draft
fix(gateway): preserve Responses tool linkage and structured output format#5624ohnoah wants to merge 1 commit intoHelicone:mainfrom
ohnoah wants to merge 1 commit intoHelicone:mainfrom
Conversation
|
@ohnoah is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two Responses API mapping issues in the gateway conversion layer:
function_calllinkage now preferscall_idover opaqueidwhen constructing Chat Completionstool_calls[].id.text.formatis now mapped to Chat Completionsresponse_format(includingjson_schemashape conversion).Why
function_call_outputlinks bycall_id. Preferringidcould create mismatches and orphaned tool outputs.text.format(e.g.responses.parse) were not propagated into chatresponse_format, causing unconstrained plain-text output in provider-mapped flows.Changes
resolveFunctionCallLinkId()and switched tool-call ID selection to usecall_idfirst.mapTextFormatToChatResponseFormat()to convert Responsestext.formatinto Chatresponse_format, includingjson_schemamapping to{ type: "json_schema", json_schema: { ... } }.openai-chat-to-responses-converters.test.ts:call_idoveridfor function callstext.formatjson_schema into chatresponse_formatValidation
corepack yarn jest --config packages/jest.config.ts packages/__tests__/llm-mapper/openai-chat-to-responses-converters.test.tscorepack yarn jest --config packages/jest.config.ts packages/__tests__/llm-mapper