Skip to content

Conversation

@eranl
Copy link
Contributor

@eranl eranl commented Nov 17, 2025

Subtract toolbarKeyLayoutParams.width instead of a hard-coded value.

Trying to fix #2103.

@Helium314
Copy link
Owner

Could you mark it as draft while you're trying to figure out what's going on (as per discussion)?

I think you can reproduce it with the clipboard too: enable the close button also for clipboard suggestions, copy a long text, restart the app. It's worse if you have pinned toolbar keys.

@eranl eranl marked this pull request as draft November 18, 2025 16:39
@eranl
Copy link
Contributor Author

eranl commented Nov 18, 2025

Could you mark it as draft while you're trying to figure out what's going on (as per discussion)?

Done.

I think you can reproduce it with the clipboard too: enable the close button also for clipboard suggestions, copy a long text, restart the app. It's worse if you have pinned toolbar keys.

It works fine for me. Can you reproduce it?

@Helium314
Copy link
Owner

Can you reproduce it?

Yes, pretty reliably. Will have a closer look.

@Helium314
Copy link
Owner

btw I like how the test build fails because GitHub is unable to access GitHub
Error: fatal: unable to access 'https://github.com/Helium314/HeliBoard/': The requested URL returned error: 503

@Helium314
Copy link
Owner

Helium314 commented Nov 19, 2025

Will have a closer look.

In this case the suggestionsStrip.width is 0, so it might be different from #2103
Looks like here the suggestion is set too early, before the suggestion strip is drawn. Not sure if this can happen with the inline autofill suggestion.

@Helium314
Copy link
Owner

Or maybe it's somehow related to adding 2 views to the suggestion strip.

@eranl eranl marked this pull request as ready for review December 1, 2025 01:40
@eranl
Copy link
Contributor Author

eranl commented Dec 1, 2025

No response to my last request, but I think we should merge this, since it is at least some improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display bug with inline suggestions

2 participants