-
-
Notifications
You must be signed in to change notification settings - Fork 217
Try to fix external suggestions width #2108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Could you mark it as draft while you're trying to figure out what's going on (as per discussion)? I think you can reproduce it with the clipboard too: enable the close button also for clipboard suggestions, copy a long text, restart the app. It's worse if you have pinned toolbar keys. |
Done.
It works fine for me. Can you reproduce it? |
Yes, pretty reliably. Will have a closer look. |
|
btw I like how the test build fails because GitHub is unable to access GitHub |
In this case the |
|
Or maybe it's somehow related to adding 2 views to the suggestion strip. |
|
No response to my last request, but I think we should merge this, since it is at least some improvement. |
Subtract
toolbarKeyLayoutParams.widthinstead of a hard-coded value.Trying to fix #2103.