fix (cli + core + hql): fixing helix push, upserts, property access, count type checking

[xav-db]

Greptile Overview

Greptile Summary

• Updates CLI/container naming logic and instance existence detection to use centralized hyphenated compose naming.
• Refactors core upsert logic (nodes/edges/vectors) to use fallible serialization and (for edges) DB lookup by (from_node, label, to_node) rather than iterator content; adds extensive traversal upsert tests.
• Extends HelixQL codegen + validation to support WHERE traversals with prefix steps before property access (issue bug (hql): WHERE(_::ToN::ID::EQ(...)) Causes Rust Codegen Failure #847) and maps Type::Count to I64.
• Adds new hql-tests fixture for traversal property access WHERE regressions and bumps crate versions/lockfiles.

Important Files Changed

Filename	Overview
Cargo.lock	Lockfile updated due to crate version bumps; no reviewable logic changes.
helix-cli/Cargo.toml	Bumps helix-cli version from 2.2.7 to 2.2.8.
helix-cli/src/commands/push.rs	Updates displayed container name to hyphenated format; relies on DockerManager naming (OK).
helix-cli/src/docker.rs	Aligns instance existence check with centralized naming by using container_name() and exact match.
helix-db/Cargo.toml	Bumps helix-db version from 1.2.7 to 1.2.8.
helix-db/src/helix_engine/tests/traversal_tests/upsert_tests.rs	Expands upsert traversal tests, including regression coverage for edge upsert ignoring iterator content.
helix-db/src/helix_engine/traversal_core/ops/util/upsert.rs	Refactors upsert adapters to use fallible serialization and new edge lookup by (from,label,to); introduces new DuplicateKey mapping behavior reliance.
helix-db/src/helix_engine/types.rs	Adds EncodeError and more granular heed error mapping, but removes KeyExist->DuplicateKey mapping (regression for unique index handling).
helix-db/src/helixc/analyzer/methods/traversal_validation.rs	Adds validation mapping for Type::Count to I64 field type.
helix-db/src/helixc/generator/traversal_steps.rs	Adds special-case codegen for WHERE traversals with prefix steps before property/reserved property access; needs care but addresses issue #847 tests.
hql-tests/Cargo.lock	HQL tests lockfile updated; no direct logic changes.
hql-tests/tests/where_traversal_property_access/helix.toml	Adds new hql-tests fixture configuration for traversal property access WHERE cases.
hql-tests/tests/where_traversal_property_access/queries.hx	Adds regression queries for WHERE clauses with traversal prefix steps before property/reserved property access (issue #847).
hql-tests/tests/where_traversal_property_access/schema.hx	Adds schema for new traversal property access WHERE test fixture.

Sequence Diagram

sequenceDiagram
    participant CLI as helix-cli
    participant Docker as DockerManager
    participant Engine as helix-db traversal engine
    participant LMDB as LMDB/heed

    CLI->>Docker: push/start local instance
    Docker->>Docker: compose_project_name() / container_name()
    Docker-->>CLI: container name used for status + display

    CLI->>Docker: instance_exists(instance)
    Docker->>Docker: get_project_status()
    Docker-->>CLI: true/false based on exact container name match

    CLI->>Engine: run traversal with UpsertE/UpsertN
    Engine->>LMDB: upsert_n: serialize props, update secondary indexes
    Engine->>LMDB: upsert_e: lookup existing edge by (from,label,to)
    alt edge exists
        Engine->>LMDB: update edge bytes in edges_db
    else new edge
        Engine->>LMDB: append edge + update out_edges_db/in_edges_db
    end

    Engine->>Engine: map heed errors -> GraphError
    note over Engine,LMDB: KeyExist should map to DuplicateKey for unique indexes

Loading

[greptile-apps]

_{14 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (1)

helix-cli/src/commands/start.rs
Container name mismatch

This prints helix_{project_name}_{instance_name} but the CLI now uses hyphenated compose/project naming (helix-{project}-{instance}) elsewhere (e.g. DockerManager::compose_project_name and push.rs). This will display the wrong container name to users.

                &format!("helix-{project_name}-{instance_name}"),