fix(core): date parsing ordering violation

[xav-db]

Greptile Overview

Greptile Summary

Fixed a critical Ord trait violation in the Value enum's comparison implementation. Previously, incomparable types (e.g., Date vs non-parseable String, or mismatched variants) returned Ordering::Equal, which violates Rust's Ord contract since a.cmp(b) == Equal should only occur when a == b.

Changes:

• Added variant_order() helper method that assigns a deterministic u8 ordering value to each Value variant
• Replaced Ordering::Equal fallback cases with self.variant_order().cmp(&other.variant_order())
• Ensures total ordering across all Value types, preventing potential undefined behavior in sorting algorithms and data structures

Impact:
This fix prevents subtle bugs in any code that relies on sorting or ordering Value types, particularly when dealing with heterogeneous data.

Important Files Changed

Filename	Overview
helix-db/src/protocol/value.rs	Fixed Ord trait violation by using variant ordering instead of Equal for incomparable types. Added variant_order() helper method for consistent type ordering.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant Value_Ord
    participant variant_order
    
    Caller->>Value_Ord: cmp(self, other)
    
    alt Same type comparison
        Value_Ord->>Value_Ord: Direct comparison (String, Date, etc.)
        Value_Ord-->>Caller: Ordering result
    else Integer types
        Value_Ord->>Value_Ord: Convert to i128 and compare
        Value_Ord-->>Caller: Ordering result
    else Date ↔ String
        Value_Ord->>Value_Ord: Try parse String as Date
        alt Parse successful
            Value_Ord->>Value_Ord: Compare dates
            Value_Ord-->>Caller: Ordering result
        else Parse failed (NEW)
            Value_Ord->>variant_order: Get variant order for self
            Value_Ord->>variant_order: Get variant order for other
            variant_order-->>Value_Ord: u8 ordering values
            Value_Ord->>Value_Ord: Compare u8 values
            Value_Ord-->>Caller: Deterministic ordering
        end
    else Incomparable types (NEW)
        Value_Ord->>variant_order: Get variant order for self
        Value_Ord->>variant_order: Get variant order for other
        variant_order-->>Value_Ord: u8 ordering values
        Value_Ord->>Value_Ord: Compare u8 values
        Value_Ord-->>Caller: Deterministic ordering
    end

Loading

[xav-db]

@greptile