Add build options support to ComputeKernel interface#5
Merged
Hellblazer merged 1 commit intomainfrom Jan 24, 2026
Merged
Conversation
- Add compile(source, entryPoint, buildOptions) method for GPU auto-tuning - Add recompile(source, entryPoint, buildOptions) for runtime optimization - Implement both methods in OpenCLKernel backend - Default implementations throw UnsupportedOperationException - Comprehensive test suite with 22 tests covering: * Preprocessor defines and compiler flags * Recompilation with different options * Vendor-specific options (NVIDIA, AMD, Intel) * Edge cases (null, empty, conflicting options) * Execution verification with defines * Backward compatibility References: Luciferase-qt0p (Phase 4 P4.1)
Hellblazer
added a commit
that referenced
this pull request
Jan 24, 2026
- Fix misleading recompile() javadoc: clarify that old kernel resources are released immediately - Add thread safety documentation to recompile() with exclusive access requirement - Enhance error message for double-compilation to suggest using recompile() - Add security note to compile(buildOptions) about unsanitized compiler options - Simplify logging format in compileInternal() - Add javadoc to key test methods for clarity Addresses code review feedback from build options feature (PR #5). All documentation improvements, no functional changes.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add build options support to GPU kernels for runtime auto-tuning through preprocessor defines and compiler flags.
Changes
compile(source, entryPoint, buildOptions)default method to ComputeKernel interfacerecompile(source, entryPoint, buildOptions)method for runtime kernel optimizationFeatures
Code Quality
✅ No critical issues
✅ Code review approved (9/10)
✅ 526 lines of test coverage
✅ Resource cleanup verified
✅ API design excellent (default method pattern)
Test Plan
References: Luciferase-qt0p (Phase 4 P4.1)