chore: update docker-compose.yml and docs RSSHub config#617
chore: update docker-compose.yml and docs RSSHub config#617TonyRL merged 1 commit intoHenryQW:mainfrom
Conversation
…le external network access
📝 WalkthroughWalkthroughThese changes update RSSHub port references from 3000 to 1200 in documentation files and add clarifying comments to the Docker configuration. No functional logic is altered; modifications are documentation and configuration annotations only. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docker-compose.yml (1)
83-83: Consider removingpublic_accessfrom RSSHub if external access is not required.The commented RSSHub configuration includes the
public_accessnetwork, but since TTRSS communicates with RSSHub viaservice.rsshub:1200on the internal Docker network, only theservice_onlynetwork is necessary. Thepublic_accessnetwork is intended for external access (e.g., TTRSS UI), which RSSHub doesn't need unless you plan to expose it externally. Removing it would keep the configuration minimal and focused.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docker-compose.yml` at line 83, Remove the unnecessary public_access network entry from the RSSHub service definition in docker-compose.yml: update the RSSHub service (referenced as RSSHub / service.rsshub:1200) to only use the service_only network by deleting the commented or active "- public_access" line so RSSHub is not bound to the external network unless you intentionally need external exposure.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docker-compose.yml`:
- Line 83: Remove the unnecessary public_access network entry from the RSSHub
service definition in docker-compose.yml: update the RSSHub service (referenced
as RSSHub / service.rsshub:1200) to only use the service_only network by
deleting the commented or active "- public_access" line so RSSHub is not bound
to the external network unless you intentionally need external exposure.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5ee293b5-7b3a-4df8-bd93-f8701809564a
📒 Files selected for processing (3)
docker-compose.ymldocs/index.mddocs/zh/index.md
chore: update RSSHub port in Docker Compose examples to 1200 and add the public_access network so RSSHub can access websites
Summary by CodeRabbit