Skip to content

testitems + remove issame#60

Merged
ReubenJ merged 12 commits intomasterfrom
redefine-equivalences
Mar 20, 2026
Merged

testitems + remove issame#60
ReubenJ merged 12 commits intomasterfrom
redefine-equivalences

Conversation

@dekelzeldov
Copy link
Copy Markdown
Member

@dekelzeldov dekelzeldov commented Mar 18, 2026

Align to use testitems and ReTestItems with runtests, so we can use the testing interface on VSCode.

Remove 'issame' and define 'isequal' to perform the checks instead (no need to distinguish).

@dekelzeldov dekelzeldov requested a review from ReubenJ March 18, 2026 11:28
@dekelzeldov dekelzeldov self-assigned this Mar 18, 2026
@dekelzeldov dekelzeldov linked an issue Mar 18, 2026 that may be closed by this pull request
@dekelzeldov dekelzeldov added the bug Something isn't working label Mar 18, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.18%. Comparing base (359bbc5) to head (f8f9f0c).

Files with missing lines Patch % Lines
src/indexing.jl 0.00% 1 Missing ⚠️
src/rulenode.jl 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   95.13%   95.18%   +0.05%     
==========================================
  Files           4        4              
  Lines         267      270       +3     
==========================================
+ Hits          254      257       +3     
  Misses         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ReubenJ
ReubenJ previously approved these changes Mar 20, 2026
Copy link
Copy Markdown
Member

@ReubenJ ReubenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 pending formatting

@dekelzeldov dekelzeldov marked this pull request as ready for review March 20, 2026 10:33
@ReubenJ ReubenJ dismissed their stale review March 20, 2026 11:41

Dekel might have found an issue with this in the tutorial notebooks

@ReubenJ ReubenJ self-requested a review March 20, 2026 12:42
Copy link
Copy Markdown
Member

@ReubenJ ReubenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutorial notebook fixed in Herb-AI/Herb.jl#198

@ReubenJ ReubenJ merged commit b11f526 into master Mar 20, 2026
3 of 4 checks passed
@ReubenJ ReubenJ deleted the redefine-equivalences branch March 20, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update <:AbstractRuleNode equivalences

3 participants