Add method for generated interpreters without input#51
Open
Add method for generated interpreters without input#51
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 69.11% 69.41% +0.29%
==========================================
Files 3 3
Lines 204 206 +2
==========================================
+ Hits 141 143 +2
Misses 63 63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
f632488 to
f3debbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the following use-case:
HerbInterpret.jl/test/make_interpreter_tests.jl
Lines 81 to 98 in 48a66e2
Additionally, relax the type bounds on the
inputargument for generated interpreters. Previously, it wasDict{Symbol,Any}matching only dictionaries with an explicitAnytype for the values, where we actually wanted to allow for dictionaries with any type of value<:Any.While we're at it, switch to
ReTestItems.