Skip to content

Conversation

KaranDuggal
Copy link
Contributor

@KaranDuggal KaranDuggal commented Aug 10, 2025

I have tested this changes on linux(ubuntuOS). it's working fine

Note: i have not tested this changes on windows and Mac

feature request: #4788


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@KaranDuggal
Copy link
Contributor Author

We already have the showConfigFileInFolder function, as you can see in the image. However, inside this function, we are not showing the file in a folder; we are opening it. But when we try to open it, we get an "access denied" error.

image

we are can calling this function

onclick: () => window.api.showConfigFileInFolder(appName),
here.

For this PR, I have created a new event because I’m not sure about using this event. Kindly let me know if I can modify this code with the new changes.

@arielj
Copy link
Collaborator

arielj commented Aug 21, 2025

the showConfigFileInFolder function has a confusing name, it should be openConfigFile or something like that, I think it's fine to have a new function to open the folder

I think it's a good opportunity to do both changes here:

  • rename the current showConfigFileInFolder to openConfigFile and change where used
  • name your new function showConfigFileInFolder

@KaranDuggal
Copy link
Contributor Author

@arielj I have renamed the functions that I created and tested them. However, for the functions that already existed, I was not able to test them because I couldn’t find the corresponding button in the UI.

It would be very helpful if you could guide me in locating this button. Once I find it, I will test the functions and update you.

Thank you.

@arielj
Copy link
Collaborator

arielj commented Aug 24, 2025

@arielj I have renamed the functions that I created and tested them. However, for the functions that already existed, I was not able to test them because I couldn’t find the corresponding button in the UI.

It would be very helpful if you could guide me in locating this button. Once I find it, I will test the functions and update you.

Thank you.

you have to go to the general settings in the sidebar, then right click the background of that screen and a context menu pops up (it's really bad UX, I know haha)

@KaranDuggal
Copy link
Contributor Author

@arielj shell.openPath(url) line of code is trying to open the file directly, and we are getting an access denied error. Should I replace this line with showItemInFolder(path.join(gamesConfigPath, \${appName}.json))`?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants