[tech] Update all builder components to their latest versions.#5176
[tech] Update all builder components to their latest versions.#5176a5ehren wants to merge 1 commit intoHeroic-Games-Launcher:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
a5ehren
force-pushed
the
update_builders
branch
from
224c625 to
38a17b8
Compare
|
a5ehren
force-pushed
the
update_builders
branch
from
38a17b8 to
ee7bb17
Compare
OK, the problem here was me removing the ts-morph override, which put it back to an old version that can't read the code. I've bumped it to match our current TS version and it passes locally. It looks like all of these checkers conceded the space to https://knip.dev/ so I'll see about getting a config for that in another PR. |
a5ehren
force-pushed
the
update_builders
branch
2 times, most recently
from
8df1dc0 to
f4f0603
Compare
| @@ -1,4 +1,4 @@ | |||
| import { defineConfig, externalizeDepsPlugin } from 'electron-vite' | |||
There was a problem hiding this comment.
These changes are from electron-vite deprecating this plugin and moving it to the main build options
| }, | ||
| "resolutions": { | ||
| "ts-morph": "17.0.1" | ||
| "ts-morph": "26.0.0" |
There was a problem hiding this comment.
This needs to be bumped to keep up with the TS package - without the override, ts-prune installs v13 of ts-morph, which does not really understand modern TS.
| - '@parcel/watcher' | ||
| - '@swc/core' | ||
| - electron | ||
| - electron-winstaller |
There was a problem hiding this comment.
these are new pnpm-install scripts from the bumped dependencies. they don't really matter, but it gets rid of an annoying warning to allow them
a5ehren
force-pushed
the
update_builders
branch
2 times, most recently
from
567b08d to
6f76717
Compare
flavioislima
force-pushed
the
main
branch
2 times, most recently
from
ce6430e to
d876444
Compare
a5ehren
force-pushed
the
update_builders
branch
3 times, most recently
from
42f92e2 to
300eb97
Compare
|
Apologize for the gore on that last force-push, but apparently the JS ecosystem has suddenly decided to favor single-quotes. pnpm and prettier did the same thing when asked? Not sure exactly. |
a5ehren
force-pushed
the
update_builders
branch
4 times, most recently
from
12d3479 to
49b2130
Compare
* Note: You must `pnpm rm electron-builder; pnpm add -D electron-builder@latest` to update that package, else the lockfile does not properly update all the Peers. It is not clear if this is an electron-builder bug or pnpm bug. * Note 2: You must `pnpm rm electron-vite @vitejs/plugin-react-swc vite-plugin-svgr; pnpm add -D electron-vite; pnpm add -D @vitejs/plugin-react-swc vite-plugin-svgr` to get an updated version of the vite compiler.
a5ehren
force-pushed
the
update_builders
branch
from
49b2130 to
c06597d
Compare
2 participants
Note: You must
pnpm rm electron-builder; pnpm add -D electron-builder@latestto update that package, else the lockfiledoes not properly update all the Peers. It is not clear if this is
an electron-builder bug or pnpm bug.
Note 2: You must
pnpm rm electron-vite @vitejs/plugin-react-swc vite-plugin-svgr; pnpm add -D electron-vite; pnpm add -D @vitejs/plugin-react-swc vite-plugin-svgrto get an updated versionof the vite compiler.
Afaict there are no breaking changes or massive updates in any of these packages, but its just another step on the road to React 19.
Use the following Checklist if you have changed something on the Backend or Frontend: