Skip to content

[UX] Fix mix between default prefixes dir and shared prefix dir#5336

Open
arielj wants to merge 1 commit intomainfrom
clean-up-default-prefix-setting
Open

[UX] Fix mix between default prefixes dir and shared prefix dir#5336
arielj wants to merge 1 commit intomainfrom
clean-up-default-prefix-setting

Conversation

@arielj
Copy link
Copy Markdown
Collaborator

@arielj arielj commented Feb 19, 2026

This PR makes the final changes so it closes #3274

This renames the variables and setting keys we use to make it more clear that one is the default prefixes folder (where prefixes are created inside) and the default (now shared) wine prefix dir (the one used with the "Use shared Wine prefix").

The new setting value is only applied for new installation or if a user resets Heroic, for existing users this should not change anything (it means that if they already have the base prefixes dir as .../default it will continue like that and prefixes will be created inside it, to not break things for them).

Similar thing happens with the default wine prefix config, now it's renamed to sharedWinePrefix so it matches better the Use shared Wine prefix option. For existing user we still show the previous value they have (they probably have .../default) and for new users we show .../shared instead.

This will solve this issue where users end up with .../Prefixes/default as a prefix and also .../Prefixes/default/some game prefix here as other prefixes inside that one.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team and Etaash-mathamsetty February 19, 2026 23:16
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 19, 2026
@arielj arielj requested review from CommandMC, Nocccer, biliesilva, flavioislima and imLinguin and removed request for a team February 19, 2026 23:16
@flavioislima flavioislima modified the milestones: 2.20, 2.21 Feb 20, 2026
Copy link
Copy Markdown
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here and I can confirm that it changes to shared only on new installs. On current configs it keeps using the default one.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default wine prefix settings and behavior are confusing

2 participants