[UX] Fix mix between default prefixes dir and shared prefix dir#5336
Open
[UX] Fix mix between default prefixes dir and shared prefix dir#5336
Conversation
flavioislima
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR makes the final changes so it closes #3274
This renames the variables and setting keys we use to make it more clear that one is the default prefixes folder (where prefixes are created inside) and the default (now
shared) wine prefix dir (the one used with the "Use shared Wine prefix").The new setting value is only applied for new installation or if a user resets Heroic, for existing users this should not change anything (it means that if they already have the base prefixes dir as .../default it will continue like that and prefixes will be created inside it, to not break things for them).
Similar thing happens with the
defaultwine prefix config, now it's renamed tosharedWinePrefixso it matches better theUse shared Wine prefixoption. For existing user we still show the previous value they have (they probably have .../default) and for new users we show .../shared instead.This will solve this issue where users end up with
.../Prefixes/defaultas a prefix and also.../Prefixes/default/some game prefix hereas other prefixes inside that one.Use the following Checklist if you have changed something on the Backend or Frontend: