[UX] Add back prime check with more information#5411
Conversation
arielj
requested review from
a team,
CommandMC,
Etaash-mathamsetty,
biliesilva,
flavioislima and
imLinguin
and removed request for
a team
CommandMC
left a comment
CommandMC
left a comment
There was a problem hiding this comment.
On the Wiki: I don't think having a list of models makes sense. Most of these graphics cards have desktop & laptop variants, so just the model number alone is not enough to verify Optimus being in use
| // if not linux, hide this setting | ||
| // if only 1 GPU is detected, hide it, but only if this was unset | ||
| // we want to still show it if less than 1 GPU and is set so users can disable it | ||
| if (!isLinux || (numberOfGPUs < 2 && !nvidiaPrime)) { |
There was a problem hiding this comment.
I added one more change here, if a user has the setting enabled and for some reason their setup changes and they don't have 2 GPUs, we have to still show the option so users can disable it
I'm not sure exactly how this works but we had a report of a user changing from nvidia to amd with this setup already turned on and maybe this is needed just in case for people to turn off the setting (I think users will still have 2 GPU if replaced, but if the dGPU is removed and we still have the env variables set I think it can create issues)
| handleChange={() => setNvidiaPrime(!nvidiaPrime)} | ||
| title={t( | ||
| 'setting.nvidiaprime.description', | ||
| 'Force use of NVIDIA Optimus or AMD Dynamic Switchable Graphics dGPU. ONLY use this for OpenGL and Vulkan games.' |
There was a problem hiding this comment.
OpenGL and Vulkan are the only APIs on Linux. I think its redundant to mention them
There was a problem hiding this comment.
what I meant here is that it's not needed when using DXVK, I can remove that or replace it with something different
what I want to avoid is users enabling it for DXVK, what I meant there is that when the game itself uses opengl or vulkan instead of vulkan through dxvk, does that make more sense? not sure how to explain it better for the user
3 participants
This PR adds the option to configure Nvidia Optimus and AMD hybrid GPUs directly from the UI instead of the user having to set the PRIME env variables.
This was removed because users would use it incorrectly, now this PR adds a lot more information for the user to understand when they should is it and when not, with a link to this new Wiki page with even more details and the lists of GPUs that might need this, and explaining this should NOT be used for DirectX games.
With the new name of the option and all the extra context, this might fix the issue of users enabling this incorrectly and at the same time be clear enough so users that need it can use it.
I did not ad this in the Legacy tab because it's technically not Legacy, it's not that OpenGL is planned to automatically detect the correct GPU, so I put it back in Other.
Use the following Checklist if you have changed something on the Backend or Frontend: