feat: add store page link to library context menu and game details page#5445
feat: add store page link to library context menu and game details page#5445i3130002 wants to merge 2 commits intoHeroic-Games-Launcher:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Screenshots:Store in games library
Store in game details
They both work and I can see myself reaching them frequently. |
| </NavLink> | ||
| <div className="topRowWapperInner"> | ||
| {!isBrowserGame && <SettingsButton gameInfo={gameInfo} />} | ||
| {!isSideloaded && gameInfo.store_url && ( |
There was a problem hiding this comment.
I don't think this should be here, there's already the option to open the store page in the 3-dots menu, I don't think this is needed that often to justify this specific button (I have literally haven't used that option in years for example)
There was a problem hiding this comment.
Hello @arielj , thabks for your comment. I can see that we have different needs when it comes to reviewing games.
My personal scenario:
I have a ton of games from Epic for free and I usually wonder which one is good, has the controller support, game size, system requirements, what the game even is and etc. These usually force me to check the store page. It happens a lot for me to reach for it and when you check 20 games, it's way nicer to do it from the right click. But I can also see that there is no need to do so if we have all the information in the game details page (including videos and images, corrrct game size, controller, game type, etc)
There was a problem hiding this comment.
I'm not opposed to having the button in the right click menu (no idea what others think about it, we shouldn't make that menu too long either to not be annoying to use), I'm talking about this button next to the 3-dots menu in the game page that I don't think it's justified to be there when it's already in the 3-dots menu right next to it
There was a problem hiding this comment.
Great point @arielj,
The reason I added that one too is that most of the time because of my muscle memory I just click on the Game and expect to see the store page (Just like when you browse the games in stores) But the details page we have is limited and I need to go to the actual store page to even see the game images/videos.
I added that button to make it easier to use.
System requirements has a dedicated section which is reasonable and I think having one for "Add to Steam" and "Store Page" can be useful too. (We have a lot of space up there and some comfort buttons doesn't hurt.)
Although I'm happy with even the right click button.
Appreciate it
There was a problem hiding this comment.
but then... why not add a button for each of the options in the 3-dots menu? some users may use them often too, it's too easy to overdo that and end up with noise for most users for a preference of some users, what's why I would keep this just in the 3-dots menu, if the reason is "I expect to see it there" if feels like a preference and we would have to accept that for any other request
if we had more requests by many users for something like that then it would make more sense to be more accessible as a general usability problem, but I haven't seen that requested
There was a problem hiding this comment.
Great. I will remove it and hopefully we can merge the right click menu.
🙏
3 participants
Summary
store_url(Epic, GOG, etc.)Files changed
src/frontend/screens/Library/components/GameCard/index.tsx— new context menu itemsrc/frontend/screens/Game/GamePage/index.tsx— new top bar buttonsrc/frontend/screens/Game/GamePage/index.css— button stylingTest plan
store_url→ no store page button shownDue to epic game login issues I could not verify the changes.