[FIX] Do not reinstall GPTK if WineCrossover or WineStaging or Crossover are installed#5451
Open
[FIX] Do not reinstall GPTK if WineCrossover or WineStaging or Crossover are installed#5451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #5428
We were always installing GPTK-Latest if no version of GPTK was found on the system, even when the user explicitly uninstalled it and made Wine-Staging the default or when Crossover is available (which has better compatibility than GPTK).
This respect that by checking not only if gptk is found but also if there's any other installed wine through the Wine Manager and if Crossover is installed.
Use the following Checklist if you have changed something on the Backend or Frontend: