Skip to content

[UX] Show a message to the user suggesting disabling verbose logs#5452

Open
arielj wants to merge 1 commit intomainfrom
disable-logs-hint
Open

[UX] Show a message to the user suggesting disabling verbose logs#5452
arielj wants to merge 1 commit intomainfrom
disable-logs-hint

Conversation

@arielj
Copy link
Copy Markdown
Collaborator

@arielj arielj commented Apr 2, 2026

This might be a solution for #5134

Currently, we have logs enabled by default to make support and troubleshooting easier, but when a game is already working correctly there's no real need to keep the verbose logs enabled and for some games with too much output this can really hurt performance.

This PR adds a message next to the play button suggesting the user to disable logs if they are enabled and the total played time is more than 5 minutes (I imagine that if there's a 5 minutes play time it means the game runs, which I think it's good enough).

This way, users can see the message and turn off the verbose logs and also learn about this and the possible impact.

Captura de pantalla 2026-04-02 a la(s) 12 55 56 a  m (the screenshot shows the message for a game with more than 1 minute, but I changed to 5 after taking the screenshot)

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, Etaash-mathamsetty and flavioislima and removed request for a team April 2, 2026 04:04
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 2, 2026
'Looks like the game is working. You might want to disable verbose logs for better performance. Click the ^ icon and use the "Play Now" button without logs'
)}
</span>
)}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only change in this return value is this added element above .playButtons, the rest did't change, it's just the diff messed up because of the updated indentation adding a <></> wrapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant