Skip to content

Title colours incorrect in dark mode #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lawmaestro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Title colours incorrect in dark mode #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion HMSegmentedControl/HMSegmentedControl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,12 @@ - (NSAttributedString *)attributedTitleAtIndex:(NSUInteger)index {

// the color should be cast to CGColor in order to avoid invalid context on iOS7
UIColor *titleColor = titleAttrs[NSForegroundColorAttributeName];


// Core Animation objects (in this case, CATextLayer) won't reflect a change in the current trait collection. So we need to resolve explicitly.
if (@available(iOS 13.0, *)) {
titleColor = [titleColor resolvedColorWithTraitCollection: UITraitCollection.currentTraitCollection];
}

if (titleColor) {
NSMutableDictionary *dict = [NSMutableDictionary dictionaryWithDictionary:titleAttrs];

Expand Down