-
Notifications
You must be signed in to change notification settings - Fork 150
Frontend: Создание компонента "Регистрации" #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Добавить скрины в ПР |
Добавил |
| "@mantine/core": "^8.3.10", | ||
| "@mantine/form": "^8.3.10", | ||
| "@mantine/hooks": "^8.3.10", | ||
| "@tailwindcss/vite": "^4.1.17", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не нужны было tailwind затаскивать, сама форма аутентификации есть здесь https://ui.mantine.dev/category/authentication/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
макеты в тасках примерные, делаем на мантине
| </Title> | ||
| </Container> | ||
| </Center> | ||
| <Demo /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ты взорвешься на мерджах, тебе нужно будет каждый раз изменения затаскивать других виджетов.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
здесь должен быть реэкспорт но вообще для страниц это может быть избыточно, т е можно делать просто login/LoginPage без индексов и без ui.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
удалить если не используется
|
|
||
| return ( | ||
| <div className="bg-[#181a1b] flex flex-col min-h-screen"> | ||
| <header className="bg-[#1d1f21]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а что меню с хедером делает в форме регистрации? это вообще отдельный виджет должен быть
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Так и вернул бы здесь провайдер уже с конфигами? Зачем удалять, если другие провайдеры в app архитектурно также сделаны.
| @tailwind components; | ||
| @tailwind utilities; | ||
|
|
||
| html, body, #root { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай пока без этих стилей, зачем они нужны?
| "@mantine/form": "^8.2.1", | ||
| "@mantine/hooks": "^8.2.1", | ||
| "add": "^2.0.6", | ||
| "@mantine/core": "^8.3.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
поднятие версий tailwindcss потребовал?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
смысла в нем сейчас особо нет
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
На utils это не очень похоже + это должен быть сегмент shared/utils
Задача: #789
Создал компонент RegisrtationForm
Сделал локализацию для текстового содержимого
Desktop

768х1024

375х667
