Avoiding issues when propagating a laser with dt=0#1219
Open
EyaDammak wants to merge 16 commits intoHi-PACE:developmentfrom
Open
Avoiding issues when propagating a laser with dt=0#1219EyaDammak wants to merge 16 commits intoHi-PACE:developmentfrom
EyaDammak wants to merge 16 commits intoHi-PACE:developmentfrom
Conversation
Contributor
Author
|
What do you think we should do? Solution A) or B) |
EyaDammak
changed the title
Member
|
I would prefer B). I wonder what Maxence thinks about this. |
MaxThevenet
reviewed
Mar 31, 2025
Member
MaxThevenet
left a comment
MaxThevenet
left a comment
There was a problem hiding this comment.
Thanks for this PR! Having to specify dt (or any parameter) although unnecessary is IMO a bit confusing. I would therefore recommend to keep dt optional, default 0, and indeed assert that dt > 0 (not only non-zero!) when laser is used. Then, if needed, the CI input files should be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request kept the parameter
hipace.dtoptional, default 0 ; but asserts that dt > 0 (not only non-zero!) when laser is used.3 CI input scripts + json files have been updated.