Remove clight factor from u#1311
Merged
MaxThevenet merged 10 commits intoHi-PACE:developmentfrom Nov 25, 2025
Merged
Conversation
MaxThevenet
reviewed
Nov 25, 2025
Member
MaxThevenet
left a comment
There was a problem hiding this comment.
Nice cleaning, thanks for this PR!
MaxThevenet
approved these changes
Nov 25, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the factor of clight from the momentum arrays of beam and plasma particles. Whereas before the proper velocity was stored in
u, now it is the normalized momentum= gamma * beta. This is much cleaner because it matches what is output to the user, saving many conversions between the two formats. In exchange, the particle pusher now normalizes the electric field with1/c.This seems to give a slight performance improvement:
PR
dev
I made sure that radiation reactions still work even in normalized units with the constants canceled out:
constisconst)