Skip to content

Remove using namespace amrex from HpMultiGrid.cpp#1326

Merged
MaxThevenet merged 5 commits intoHi-PACE:developmentfrom
AlexanderSinn:Remove_using_namespace_amrex_from_HpMultiGrid_cpp
Jan 27, 2026
Merged

Remove using namespace amrex from HpMultiGrid.cpp#1326
MaxThevenet merged 5 commits intoHi-PACE:developmentfrom
AlexanderSinn:Remove_using_namespace_amrex_from_HpMultiGrid_cpp

Conversation

@AlexanderSinn
Copy link
Copy Markdown
Member

@AlexanderSinn AlexanderSinn commented Dec 10, 2025

Factored out of #1325

In hipace we want to avoid using namespace amrex to make it clear which parts are from amrex and which are from hipace

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added the cleaning Code cleaning, avoid duplication, better naming, better style etc. label Dec 10, 2025
@AlexanderSinn AlexanderSinn mentioned this pull request Jan 12, 2026
9 tasks
@MaxThevenet MaxThevenet merged commit 28df1f9 into Hi-PACE:development Jan 27, 2026
11 checks passed
@AlexanderSinn AlexanderSinn deleted the Remove_using_namespace_amrex_from_HpMultiGrid_cpp branch April 8, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleaning Code cleaning, avoid duplication, better naming, better style etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants