Mesh refinement: Adding IO#526
Merged
SeverinDiederichs merged 9 commits intoHi-PACE:developmentfrom Jun 14, 2021
Merged
Conversation
This was referenced Jun 12, 2021
MaxThevenet
reviewed
Jun 14, 2021
Member
MaxThevenet
left a comment
There was a problem hiding this comment.
Looks good, thanks! See a few comments below.
MaxThevenet
approved these changes
Jun 14, 2021
Member
|
Awesome! :) Let me cross-link the WarpX implementation and definitions we drafted for the openPMD standard:
Note that the WarpX implementation currently still over-allocates file size for the refined level for HDF5 (we use this with ADIOS2 at the moment). A follow-up PR tuning HDF5 further would only declare a smaller box per patch on the refined level to work-around this, as noted in both links :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a first working version of IO of the refined level.
In the
OpenPMDWriterclass, the series is now a vector over levels. Each level has its own series and writes to its own sub-folder in the IO path. If only the 0th level is used, no sub-folders will be generated.Then, the IO is now a loop over levels. Additionally, the copying of the slice to the diagnostics is now a loop over levels.
The resizing of the diagnostic arrays is a loop over levels. To not yet touch the other functions, it is done with local variables.
To avoid complications with the Poisson solver (the staging area needs to exist per level), the Poisson solver is not even allocated for other levels than lev = 0. This is handled in #527.
Additionally, the boxarray for the first level is not set correctly.
In the current version, the code crashes if used with a beam in the binning. No beam can be used with MR at this point.
constisconst)