[FIX/#739] Mark delete functionality as deprecated#740
Merged
Conversation
- Comment out diary deletion UI components in DiaryFeedbackScreen, HomeDropDownMenu, and FeedbackMenuBottomSheet - Mark deleteDiary methods in DiaryRepository, HomeViewModel, and DiaryFeedbackViewModel as deprecated - Replace active deletion callbacks with empty lambdas in DiaryFeedbackScreen and HomeScreen - Add code comments indicating that deletion functionality is suspended until the introduction of the edit feature
angryPodo
requested review from
Daljyeong,
Hyobeen-Park,
nahy-512 and
nhyeonii
and removed request for
a team
nhyeonii
approved these changes
Mar 16, 2026
Collaborator
nhyeonii
left a comment
nhyeonii
left a comment
There was a problem hiding this comment.
@deprecated 어노테이션 오랜만에 보는 것 같아요 !! 디스코드 스레드 확인했었는데 빠르게 작업해주시느라 너무 고생하셨습니다 🚀
nahy-512
approved these changes
Mar 16, 2026
Member
nahy-512
left a comment
nahy-512
left a comment
There was a problem hiding this comment.
메소드에 Deprecated 쓴 거 좋네요ㅎㅎ 고생하셨습니다!
angryPodo
added a commit
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
deleteDiary()함수 Deprecated 처리Screenshot 📸
_03.16._15.11.mp4
_03.16._14.55.mp4
To Reviewers 📢
자세한 논의는 회의 스레드 참고 바랍니다👍🏻