Skip to content

Add mod10 chi validation #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdteviotdale merged 4 commits into from
Jan 29, 2026
Merged

Add mod10 chi validation #2273

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17268a1
add mod10 chi validation
JFriel Nov 25, 2025
344899a
Merge branch 'develop' of https://github.com/HicServices/RDMP into ta…
JFriel Jan 28, 2026
64653c9
Update CHANGELOG.md
JFriel Jan 29, 2026
1c5e4c8
Merge branch 'develop' into task/RDMP-337-chi-10
JFriel Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Automatically fetch user settings from previous versions of RDMP when installing the latest version
- Allow new columns to be added to archive extractions
- Simplify use of Extraction Progress
- Update CHI validation to allow mod10 CHIs


## [9.1.1] - 2025-12-02
- Allow Atlassian service workers to write to Confluence from RDMP
Expand Down
11 changes: 8 additions & 3 deletions Rdmp.Core/Validation/Constraints/Primary/Chi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,16 @@ private static char GetCHICheckDigit([NotNull] string sCHI)
int c = '0';
for (var i = 0; i < lsCHI - 1; i++)
sum += ((int)sCHI.Substring(i, 1)[0] - c) * (lsCHI - i);
sum %= 11;
var mod11Sum = sum % 11;

c = 11 - sum;
c = 11 - mod11Sum;
if (c == 11) c = 0;

if (c != int.Parse(sCHI.Substring(9, 1)))
{
var mod10Sum = sum % 10;
c = 10 - mod10Sum;
if (c == 10) c = 0;
}
return (char)(c + '0');
}

Expand Down
4 changes: 2 additions & 2 deletions rdmp-client.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<item>
<version>9.1.1.0</version>
<url>https://github.com/HicServices/RDMP/releases/download/v9.1.0/rdmp-9.1.0-client.zip</url>
<version>9.1.2.0</version>
<url>https://github.com/HicServices/RDMP/releases/download/v9.1.2/rdmp-9.1.2-client.zip</url>
<changelog>https://github.com/HicServices/RDMP/blob/main/CHANGELOG.md#7</changelog>
<mandatory>true</mandatory>
</item>
Loading