Skip to content

Bugfix/rdmp 362 dupe list project cic#2313

Merged
JFriel merged 8 commits intodevelopfrom
bugfix/RDMP-362-dupe-list-project-cic
Mar 3, 2026
Merged

Bugfix/rdmp 362 dupe list project cic#2313
JFriel merged 8 commits intodevelopfrom
bugfix/RDMP-362-dupe-list-project-cic

Conversation

@JFriel
Copy link
Collaborator

@JFriel JFriel commented Feb 12, 2026

Proposed Change

Remove practically duplicate folders in prioject tree

Type of change

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update
  • Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Created or updated any tests if relevant
  • Have validated this change against the Test Plan
  • Requested a review by one of the repository maintainers
  • Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it
  • Have added an entry into the changelog

private CohortIdentificationConfiguration _cic;
private ProjectCohortIdentificationConfigurationAssociation[] _existingAssociations;
private ProjectCohortIdentificationConfigurationAssociation _associationToDelete;
private IBasicActivateItems _activator;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field '_activator' can be 'readonly'.

Copilot Autofix

AI about 1 month ago

To fix the problem, the private field _activator should be declared with the readonly modifier so that it can only be assigned at its declaration or within the constructor, preventing later unintended mutations.

Concretely, in Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandRemoveCohortIdentificationConfigurationProjectAssociation.cs, update the field declaration on line 27 from private IBasicActivateItems _activator; to private readonly IBasicActivateItems _activator;. No other code changes are necessary, because _activator is only assigned in the constructor and read elsewhere. No additional methods, imports, or definitions are required.

Suggested changeset 1
Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandRemoveCohortIdentificationConfigurationProjectAssociation.cs

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandRemoveCohortIdentificationConfigurationProjectAssociation.cs b/Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandRemoveCohortIdentificationConfigurationProjectAssociation.cs
--- a/Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandRemoveCohortIdentificationConfigurationProjectAssociation.cs
+++ b/Rdmp.Core/CommandExecution/AtomicCommands/ExecuteCommandRemoveCohortIdentificationConfigurationProjectAssociation.cs
@@ -24,7 +24,7 @@
     private CohortIdentificationConfiguration _cic;
     private ProjectCohortIdentificationConfigurationAssociation[] _existingAssociations;
     private ProjectCohortIdentificationConfigurationAssociation _associationToDelete;
-    private IBasicActivateItems _activator;
+    private readonly IBasicActivateItems _activator;
     public ExecuteCommandRemoveCohortIdentificationConfigurationProjectAssociation(IBasicActivateItems activator) :
         base(activator)
     {
EOF
@@ -24,7 +24,7 @@
private CohortIdentificationConfiguration _cic;
private ProjectCohortIdentificationConfigurationAssociation[] _existingAssociations;
private ProjectCohortIdentificationConfigurationAssociation _associationToDelete;
private IBasicActivateItems _activator;
private readonly IBasicActivateItems _activator;
public ExecuteCommandRemoveCohortIdentificationConfigurationProjectAssociation(IBasicActivateItems activator) :
base(activator)
{
Copilot is powered by AI and may make mistakes. Always verify output.
@JFriel JFriel marked this pull request as ready for review February 25, 2026 10:13
Copy link
Contributor

@JBaird00183 JBaird00183 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo done

@JFriel JFriel merged commit be359b2 into develop Mar 3, 2026
5 checks passed
@JFriel JFriel deleted the bugfix/RDMP-362-dupe-list-project-cic branch March 3, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants