Skip to content

Task/rdmp 360 catalogue status change behaviour #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JFriel wants to merge 10 commits into from

fix preinit invoker

cd21f6d
Select commit
Loading
Failed to load commit list.
Closed

Task/rdmp 360 catalogue status change behaviour #2314

fix preinit invoker
cd21f6d
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Feb 12, 2026 in 6s

5 new alerts

New alerts in code changed by this pull request

  • 1 warning
  • 4 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 58 in Rdmp.Core.Tests/DataExport/DataExtraction/ExecuteDatasetExtractionFlatFileDestinationTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dispose may not be called if an exception is thrown during execution Warning test

Dispose missed if exception is thrown by
call to method Add
Loading
.
Dispose missed if exception is thrown by
call to method Add
Loading
.
Dispose missed if exception is thrown by
call to method CreateNewLoggingTaskIfNotExists
Loading
.
Dispose missed if exception is thrown by
call to method CreateDataLoadInfo
Loading
.
Dispose missed if exception is thrown by
call to method GenerateQueryBuilder
Loading
.
Dispose missed if exception is thrown by
call to method PreInitialize
Loading
.
Dispose missed if exception is thrown by
call to method ProcessPipelineData
Loading
.
Dispose missed if exception is thrown by
call to method Dispose
Loading
.
Dispose missed if exception is thrown by
call to method That
Loading
.
Dispose missed if exception is thrown by
call to method Exists
Loading
.
Dispose missed if exception is thrown by
call to method That
Loading
.
Dispose missed if exception is thrown by
call to method ReadAllText
Loading
.
Dispose missed if exception is thrown by
call to method EqualTo
Loading
.

Check notice on line 79 in Rdmp.Core/CohortCreation/Execution/CohortCompiler.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field '_activator' can be 'readonly'.

Check notice on line 351 in Rdmp.Core/CohortCreation/Execution/CohortCompiler.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Where Note

This foreach loop
implicitly filters its target sequence
Loading
- consider filtering the sequence explicitly using '.Where(...)'.

Check notice on line 76 in Rdmp.UI/SubComponents/CohortIdentificationConfigurationUI.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'Common' can be 'readonly'.

Check notice on line 26 in Tools/rdmp/CommandLine/Gui/ConsoleGuiCohortIdentificationConfigurationUI.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'Common' can be 'readonly'.