Add support for ESP32 Core v3.x and ArduinoJson 7 compilation fix#634
Open
Cri4Key wants to merge 2 commits intoHieromon:masterfrom
Open
Add support for ESP32 Core v3.x and ArduinoJson 7 compilation fix#634Cri4Key wants to merge 2 commits intoHieromon:masterfrom
Cri4Key wants to merge 2 commits intoHieromon:masterfrom
Conversation
This was referenced Apr 10, 2025
|
I patched both AutoConnect and Pagebuilder using the merge above and fix all the errors with ESP32 Core v3.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ESP32 Arduino Core 3.x based on ESP-IDF 5.x breaks compatibility with the AutoConnect library. These fixes make it possible for the library to compile with Core 3.x versions and it seems to be working properly (tested on ESP32-S3).
Moreover, following change to fix compilation error when using ArduinoJson 7 on ESP32. This makes compilation possible and adds initial support but, ideally, it still needs refactoring to fix various warnings due to the use of deprecated functions:
Last change is just on a definition used only in AutoConnectCoreImpl.hpp. It doesn't do anything, but I changed it because it used to conflict with another library I used with AutoConnect: