Skip to content

Conversation

@Himanshu49
Copy link
Owner

@Himanshu49 Himanshu49 commented Oct 24, 2023


This PR is for bug fixes in our existing extension for Azure Load Testing service under "load" extension.
Changes in this PR:

  1. Changed logical implementation of a two commands.
  • Added null support for argument --certificate and --subnet in commands "az load update" and "az load create" to remove those properties from test.
  • Added support to remove certificate, subnet from config file when provided in commands "az load update" and "az load create".
  • Logical implementation changed when using config file using argument --load-test-config-file in commands "az load test update" and "az load test create".  
  1. Added a new test case to cover new cases.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Changes will be reflected for following commands "az load test create" and "az load test update".

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Himanshu49 pushed a commit that referenced this pull request Dec 26, 2023
…count container copy, api-version 2023-09-15-preview (Azure#6703)

* init changes for 20230915-preview api

* Changes to add enablePriorityBasedExecution and defaultPriorityLevel

* Removed isPreview flag from CMK related properties and added key-uri to cosmosdb update operation.

* Added test and test recording for priority based execution

* corrected resource group name and whitespace corrections

* white space corrections

* Add cosmosdb copy command

* Add tests

* Dts/cross account copy (#3)

* Deprecate old command

* Add test recording for dts

---------

Co-authored-by: Nitesh Vijay <[email protected]>

* Fix build error

* Fix Static Analysis

* Use boolean type

* Change help text

* Update help text

* Updated Vendored SDK

* Updated test account name in test_cosmosdb-merge-scenario.py

* Whitespace correction and added linter exclution for enable pbe

* Updated linter_exclusions

* Remove id part

* Corrected account name in test_cosmosdb-merge-scenario.py and generated test recordings

* Generated test recording for test_cosmosdb_materializedview

* Add support for MI Cassandra in 2023-09-15

* Add -n for jobname

* Fix breaking change

* Modified setup.py and history.rst

* Fix static check

* Whitespace correction

* Re-recorded tests

* rerecorded test test_cosmosdb_sql_materializedview_scenario

* removed linter exclusion for enable_priority_based_execution

* Rerecorded all tests

* Updated HISTORY.rst

* Rerecorded tests

* rerecorded test_cosmosdb_sql_materializedview_scenario

* rerecorded test_cosmosdb_sql_materializedview_scenario

* rerecorded tests

---------

Co-authored-by: Achint Agrawal <[email protected]>
Co-authored-by: AdrianSibajaRetana <[email protected]>
Co-authored-by: Nitesh Vijay <[email protected]>
Co-authored-by: Nitesh Vijay <[email protected]>
Co-authored-by: Guanzhou <[email protected]>
Himanshu49 pushed a commit that referenced this pull request Nov 5, 2024
* fix: --title --kind --custom-property parameters (#1)

* feat: support yaml file in register command (#3)

* fix: workspace parameter should not be required (#2)

* style: fix lint issues (#6)

* chore: update codeowner for apic-extension (#5)

* feat: revert changes to min cli version (#4)

* feat: resolve comments to CLI experience (Azure#10)

* feat: mark "apic api register" command as preview (Azure#13)

* feat: remove --terms-of-service parameter (Azure#12)

* feat: remove --workspace-name parameter (Azure#11)

* feat: support python 3.8 and 3.9 (Azure#14)

* feat: fix command descriptions (Azure#17)

* tests: add test cases for 'apic service' commands (Azure#16)

* feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (Azure#19)

* fix: CLI errors (Azure#20)

* fix: import error when run CLI command

* fix: no workspace name error when run import specification command

* feat: mark some parameters as required (Azure#21)

* feat: mark --assignments parameter required for metadata commands

* doc: update sample commands

* feat: mark --source-resource-ids parameter as required for import-from-apim command

* doc: update description for import-from-apim command

* feat: bump version to 1.0.0b5 and update changelog (Azure#18)

* build: fix ci (Azure#22)

* style: fix style warnings

* test:fix test cases

* fix: service update command failure (Azure#28)

* doc: fix command samples (Azure#30)

* doc: update changelog per feedback (Azure#29)

* doc: remove extra spaces in register command help message (Azure#34)

* doc: update api definition and metadata command samples (Azure#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants