Skip to content

Fix bugs preventing dSYM upload for development builds by using upload-symbols tool #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewhavens wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bugs preventing dSYM upload for development builds by using upload-symbols tool #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/motion-fabric.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,22 @@ def fabric_run(platform)
SRCROOT: project_dir,
PLATFORM_NAME: platform.downcase,
PROJECT_FILE_PATH: "",
CONFIGURATION: App.config_mode == 'development' ? 'debug' : 'release',
CONFIGURATION: App.config_mode == :development ? 'debug' : 'release',
}
env_string = env.map { |k,v| "#{k}='#{v}'" }.join(' ')
fabric_setup do |pods_root, api_key, build_secret|
App.info "Fabric", "Uploading .dSYM file"
system("env #{env_string} sh #{pods_root}/Fabric/run #{api_key} #{build_secret}")
if App.config_mode == :development
generic_platform = case platform
when 'iPhoneSimulator', 'iPhoneOS' then 'ios'
when 'AppleTVSimulator', 'AppleTVOS' then 'tvos'
when 'MacOSX' then 'mac'
end
system("#{pods_root}/Fabric/upload-symbols -a #{api_key} -p #{generic_platform} '#{dsym_path}'")
else
# NOTE: not sure if Fabric/run is better for release builds. Going to leave it like this for now.
system("env #{env_string} sh #{pods_root}/Fabric/run #{api_key} #{build_secret}")
end
end
end

Expand Down