Merged
Conversation
Member
joewiz
commented
May 15, 2025
joewiz
commented
- move ID-related checks into frus-id-checks.sch
- leave only structural checks in frus.sch
- add schematron quick fixes to add IDs to persName & terms and ensure uniqueness, using legacy rules for assigning IDs within a volume
- Person: "p_" + initials + "_1" (where 1 is changed to 2 if another person has already been assigned this ID in the volume, 2 to 3, and so on)
- Term: "t_" + capitals + "_1" (where 1 is changed to 2 if another term...)
- move ID-related checks into frus-id-checks.sch - leave only structural checks in frus.sch - add schematron quick fixes to add IDs to persName & terms and ensure uniqueness, using legacy rules for assigning IDs within a volume - Person: "p_" + initials + "_1" (where 1 is changed to 2 if another person has already been assigned this ID in the volume, 2 to 3, and so on) - Term: "t_" + capitals + "_1" (where 1 is changed to 2 if another term...)
joewiz
force-pushed
the
fix-persons-terms-checks
branch
from
35d23a2 to
b5f99bd
Compare
|
🎉 This PR is included in version 0.7.21 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.