Conversation
joewiz
changed the title
Member
Author
|
🎉 This PR is included in version 0.8.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by @awmarrs, the text immediately preceding footnotes 3 and 5 in https://history.state.gov/historicaldocuments/frus1981-88v38/d70 are blank gaps. The gaps are present in the PDF:
... but were not encoded in the XML, leading to omission of the space.
This PR fixes these 2 instances, using our ODD's existing support for
<gap>with@unitand@quantity. I specified@reason="lacuna", following C.M. Sperberg McQueen's suggestion from TEI-L (Feb 20, 2019) to indicate that the gap was in the original.At some point we should tidy up existing ~300 instances of
<gap>in the FRUS corpus to conform to the@unitvalues listed in the Guidelines and align with the tei.enumerated class for@reason: https://tei-c.org/release/doc/tei-p5-doc/en/html/ref-gap.html.Corresponding updates to the FRUS processing model in hsg-shell are in HistoryAtState/hsg-shell#528.