Open
Conversation
Added "normalized directory name" function for post searches to enable searching for "pool:<pool_id>".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
normalize_directory_namefunction for post searches to enable searching for "pool:<pool_id>" and saving them with a valid directory name.It is not an elegant solution, but I had an issue with only being able to download 75 images from pools; with some searching, I found that there's a default limit defined in the e621 API that gets applied, because in
endpoints.Posts'ssearch()the limit is set to None. By manually addinglimit = 1000, 100 images will download. I didn't manage to find where that limitation comes in (probably undocumented API behavior), but found a workaround:searching for posts with
pool:<pool_id>works. Obviously, the downloaded files' index number will be reversed, but otherwise should function up until the hard 320 limit set by the API, although this change for the code is needed, because it can't create a folder with:in its name.