Conversation
|
Hi @dev-luizf ! This MR is ready to review ? Or I need to wait the last TODO ? (And thank you @alanlomeli) |
I think it would be better wait the last todo and one config about atom hk that I forgot. But the other PR is ready to review. |
|
It is done @Pi-Bouf, you can review. I'm not sure if atom submodules were added, because when a ran just install in a clean instalation they were not cloned, can you check it? |
|
Any updates on this? @Pi-Bouf |
|
Sorry @dev-luizf , I will take a look really soon ! |
About the second point, you mean create atom and atom-hk folders? I don't know much about git submodules |
Yes, when you setup a submodule you got two things: an entry inside the .gitmodules and a folder referencing the cloned module / the target and which branch to use |
This PR adds atom cms and hk to the project. It was based on @alanlomeli fork here, with some changes and fixes by me.
TO DO: