Conversation
|
This commit definitely breaks networking for me. It kinda half works when you migrate from an existing install and then run the container, but only when you do not do a The resulting deployment does not result in something that lets me access cosmic cms from http://127.0.0.1/cms as the code would imply- due to some php error I did not bother to look into. EDIT: just to be clear, the issue probably is with apache configuration, which seems to be included in the php container. Regardless, I cannot get to the main landing page from outside of my VM due to how it's setting up things in iptables/apache. |
|
I'll run some tests and see if I encounter the same issues. Thanks for your feedback! |
I looked into this again, turns out the problem is with the static ip configuration you're doing. Docker on my machine creates a network in the 172.16.0.0/12 subnet and automatically assigns the IPs 172.16.0.2-4 for the containers. When I remove the 192.x.x.x/24 static ip you assign in the docker-compose.yaml there is no issue with the configuration. I am not sure why you're doing that, but it shouldn't be necessary in the out of the box implementation. You should perhaps remove your custom networking and retry a build from scratch. Leave any custom configuration to users who clone the repo. |
|
I remember it had to do something with the RCON connection (which wasn't working untill I put the static IP thing). I couldn't run tests on my computer (unrelated problems, the regular didn't work either) but I'll get on my macbook to fix this. Edit: the problem is that the emulator ( Arcturus MS) has an IP whitelist for RCON. That's why I needed a static IP for the php-apache image. I thought the edit I made in the network configuration would have forced the subnet to stick to the given ip and range. |
|
@TheRevenge it works or nope ? Now you removed static ipv4 and RCON only use |
|
Well I have a shitty internet (I'm on vacation) so I can't really run my tests |
Pi-Bouf
left a comment
There was a problem hiding this comment.
You just clear the file mysql/dumps/arcturus_3.0.0-stable_base_database--compact.sql and change rights.
We need to keep this file AND make an another one like cosmic_2.6_update.sql with all Cosmic's change.
Not just make one big file called cosmic2.6.sql
It's not the Cosmic database, it's the Arcturus database with a cosmic update :D
|
@Pi-Bouf Actually there are 3 .sql :
|
|
I believe @Pi-Bouf is saying that the "base sql for cosmic" that you have included is actually a "arcturus + cosmic" sql database. When they would prefer that the cosmic sql be only the sql needed to migrate from arcturus 3.5.0 -> cosmic. |
|
With this patch, the external dependencies would also still need to be removed. I have tried the state and it requires a login for the external Gitlab server. |
|
Is-it really useful to have a cosmic ? |
|
I think that would be useful. I would like to test a few things that I could already do via SQL. But it would be much more relaxed via a CMS. But I would not care which CMS. |
Voilà enfin la PR d'ajout de Cosmic !
N.B. : J'ai retiré le "patch sass" car c'était un bidouillage pour les machines avec un proc arm. Puis il est pas difficile à refaire :p
Si vous voyez des améliorations à faire, n'hésitez pas !