generate Chromeleon program files #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 74.57% 68.05% -6.53%
==========================================
Files 1 3 +2
Lines 59 72 +13
==========================================
+ Hits 44 49 +5
- Misses 15 23 +8
☔ View full report in Codecov by Sentry. |
timholy
reviewed
Aug 16, 2023
Member
timholy
left a comment
timholy
left a comment
There was a problem hiding this comment.
LGTM. Is everything except the chromeleon stuff just code-movement? Or were there changes?
Not very important, but maybe adding a test of a dummy file would at least ensure the code runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a way to generate .pgm files for use with Chromeleon that allow for remote triggering of injections with the autosampler.
I'm not entirely sure that this will be necessary or even convenient. Most often, the .pgm file can be easily manually changed. Since there are a lot of (unorganized) .pgm files on the HPLC laptop, it still might be helpful to have some here.