Skip to content

workflows/actionlint: fix in formulae.brew.sh.#408

Merged
ZhongRuoyu merged 1 commit intomainfrom
actionlint_formula_fix
Mar 19, 2026
Merged

workflows/actionlint: fix in formulae.brew.sh.#408
ZhongRuoyu merged 1 commit intomainfrom
actionlint_formula_fix

Conversation

@MikeMcQuaid
Copy link
Member

Don't cache the prefix for the formulae.brew.sh repository as it won't download its own JSON API files.

Should unblock Homebrew/formulae.brew.sh#2155

Don't cache the prefix for the formulae.brew.sh repository as it won't download
its own JSON API files
@ZhongRuoyu ZhongRuoyu merged commit 5da69f4 into main Mar 19, 2026
25 checks passed
@ZhongRuoyu ZhongRuoyu deleted the actionlint_formula_fix branch March 19, 2026 18:12
@ZhongRuoyu
Copy link
Member

Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Actionlint GitHub Actions workflow to avoid caching the Homebrew prefix when the workflow runs in the Homebrew/formulae.brew.sh repository, addressing an issue where that repo won’t download its own JSON API files.

Changes:

  • Adds a step-level condition to skip Homebrew/actions/cache-homebrew-prefix@main when github.repository is Homebrew/formulae.brew.sh.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 41 to 45
- uses: Homebrew/actions/cache-homebrew-prefix@main
# Don't cache the prefix for the formulae.brew.sh repository as it won't download its own JSON API files
if: github.repository != 'Homebrew/formulae.brew.sh'
with:
install: actionlint shellcheck zizmor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Copilot, will be fixed in #409.

ZhongRuoyu added a commit that referenced this pull request Mar 19, 2026
Now that we skip cache-homebrew-prefix, we need to manually install the
tools. Follow-up to #408.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants