Add regression specs for TestBot strict typing fixes

Test through public run! interfaces where practical
(BottlesFetch, CleanupAfter); use send for deeply
internal methods without a reasonable public entry point.

Author: dduugg

Library/Homebrew/test/test_bot/bottles_fetch_spec.rb

@@ -4,15 +4,17 @@
 require "dev-cmd/test-bot"
 
 RSpec.describe Homebrew::TestBot::BottlesFetch do
-  describe "#fetch_bottles!" do
+  describe "#run!" do
     it "accepts Utils::Bottles::Tag objects from the bottle collector" do
       # Regression test: bottle_specification.collector.tags returns Utils::Bottles::Tag objects,
       # not Symbols. The fetch_bottles! signature must accept Tag, not Symbol.
       fetch = described_class.new(tap: nil, git: nil, dry_run: true, fail_fast: false, verbose: false)
-      allow(fetch).to receive(:cleanup_during!)
+      fetch.testing_formulae = ["some-formula"]
       tag = Utils::Bottles::Tag.new(system: :sequoia, arch: :arm64)
+      allow(fetch).to receive(:formulae_by_tag).and_return({ tag => Set["some-formula"] })
+      allow(fetch).to receive(:cleanup_during!)
 
-      fetch.send(:fetch_bottles!, tag, Set["some-formula"], args: instance_double(Homebrew::Cmd::TestBotCmd::Args))
+      fetch.run!(args: instance_double(Homebrew::Cmd::TestBotCmd::Args))
 
       expect(fetch.steps.last).to be_passed
       expect(fetch.steps.last.command).to include("--bottle-tag=#{tag}")

Library/Homebrew/test/test_bot/formulae_spec.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require "test_bot"
+
+RSpec.describe Homebrew::TestBot::Formulae do
+  describe "#testing_portable_ruby?" do
+    it "returns false (not nil) when tap is nil" do
+      # Regression test: without `!!`, tap&.core_tap? returns nil when tap is nil,
+      # and `nil && ...` evaluates to nil, violating the T::Boolean return type.
+      Dir.mktmpdir do |tmpdir|
+        output_paths = {
+          bottle:                     Pathname.new("#{tmpdir}/bottle.txt"),
+          linkage:                    Pathname.new("#{tmpdir}/linkage.txt"),
+          skipped_or_failed_formulae: Pathname.new("#{tmpdir}/skipped.txt"),
+        }
+        formulae = described_class.new(
+          tap: nil, git: "git", dry_run: true, fail_fast: false, verbose: false,
+          output_paths:
+        )
+
+        result = formulae.send(:testing_portable_ruby?)
+        expect(result).to be(false)
+      end
+    end
+  end
+
+  describe "#verify_local_bottles" do
+    it "returns false (not nil) when testing portable ruby" do
+      # Regression test: the early return for portable ruby must be `return false`,
+      # not bare `return` (which returns nil), to satisfy the T::Boolean return type.
+      Dir.mktmpdir do |tmpdir|
+        output_paths = {
+          bottle:                     Pathname.new("#{tmpdir}/bottle.txt"),
+          linkage:                    Pathname.new("#{tmpdir}/linkage.txt"),
+          skipped_or_failed_formulae: Pathname.new("#{tmpdir}/skipped.txt"),
+        }
+        formulae = described_class.new(
+          tap: CoreTap.instance, git: "git", dry_run: true, fail_fast: false, verbose: false,
+          output_paths:
+        )
+        formulae.testing_formulae = ["portable-ruby"]
+
+        result = formulae.send(:verify_local_bottles)
+        expect(result).to be(false)
+      end
+    end
+  end
+end

Library/Homebrew/test/test_bot/junit_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "dev-cmd/test-bot"
+require "test_bot"
 
 RSpec.describe Homebrew::TestBot::Junit do
   # Regression test: Junit requires REXML before use. Without the require calls in #initialize,

Library/Homebrew/test/test_bot/test_cleanup_spec.rb

@@ -2,33 +2,38 @@
 
 require "dev-cmd/test-bot"
 
-RSpec.describe Homebrew::TestBot::TestCleanup do
+RSpec.describe Homebrew::TestBot::CleanupAfter do
   # Regression test: checkout_branch_if_needed, reset_if_needed, and clean_if_needed
-  # expect a String (repository path). Passing HOMEBREW_REPOSITORY (Pathname) causes
+  # expect a String (repository path). Passing HOMEBREW_REPOSITORY (Pathname) would cause
   # "Parameter 'repository': Expected type String, got type Pathname" in strict typing.
-  describe "cleanup_shared" do
+  describe "#run!" do
     it "passes a String to checkout_branch_if_needed, reset_if_needed, and clean_if_needed when tap is set" do
       cleanup = described_class.new(
         tap:       CoreTap.instance,
         git:       "git",
-        dry_run:   false,
+        dry_run:   true,
         fail_fast: false,
         verbose:   false,
       )
 
-      # Stub so we reach the "if tap" block without running git or deleting files.
-      allow(cleanup).to receive(:repository).and_return(Pathname.new("/nonexistent_brew_repo_#{SecureRandom.hex(8)}"))
+      # Stub to avoid actual filesystem and process operations.
+      allow(FileUtils).to receive(:chmod_R)
       allow(cleanup).to receive(:info_header)
       allow(cleanup).to receive(:delete_or_move)
+      allow(cleanup).to receive(:test)
+      allow(cleanup).to receive_messages(repository:   Pathname.new("/nonexistent_#{SecureRandom.hex(8)}"),
+                                         quiet_system: false)
       allow(Keg).to receive(:must_be_writable_directories).and_return([])
       allow(Pathname).to receive(:glob).and_return([])
-      allow(cleanup).to receive(:test)
 
       expect(cleanup).to receive(:checkout_branch_if_needed).with(String)
       expect(cleanup).to receive(:reset_if_needed).with(String)
       expect(cleanup).to receive(:clean_if_needed).with(String)
 
-      cleanup.send(:cleanup_shared)
+      args = double(test_default_formula?: false, local?: false)
+      with_env("HOMEBREW_GITHUB_ACTIONS" => nil, "GITHUB_ACTIONS" => nil) do
+        cleanup.run!(args:)
+      end
     end
   end
 end

Library/Homebrew/test/test_bot/test_formulae_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "dev-cmd/test-bot"
+require "test_bot"
 require "utils/github/artifacts"
 
 RSpec.describe Homebrew::TestBot::TestFormulae do

Library/Homebrew/test_bot/bottles_fetch.rb

@@ -1,4 +1,4 @@
-# typed: true # rubocop:todo Sorbet/StrictSigil
+# typed: strict
 # frozen_string_literal: true
 
 module Homebrew