brew.sh: enforce HOMEBREW_FORCE_BREW_WRAPPER
more strictly
#20400
+51
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?HOMEBREW_FORCE_BREW_WRAPPER
can be used as a security/compliancefeature, but allowing it to be disabled by setting
HOMEBREW_NO_FORCE_BREW_WRAPPER
leaves a pretty large hole in it thatallows it to be sidestepped.
Let's fix that by actually checking the path of the process that called
brew
, and the verify that that path matches the configured value ofHOMEBREW_NO_FORCE_BREW_WRAPPER
.