Fix/interactive prompt timeout #20401
Open
+149
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nv: HOMEBREW_NON_INTERACTIVE, HOMEBREW_PROMPT_TIMEOUT_SECS; system_command: non-interactive sudo and prompt-aware timeout with skip reporting
…-interactive skip in install cmd
…or-user to fix parser keyword error
rehkad
force-pushed
the
fix/interactive-prompt-timeout
branch
from
0f702f8 to
60f6d1e
Compare
…urn; refine timeout parsing
…pacing, generic rescue)
…MPT_TIMEOUT_SECS and HOMEBREW_NON_INTERACTIVE
…prompt_timeout to satisfy Sorbet reachability
…_INTERACTIVE and HOMEBREW_PROMPT_TIMEOUT_SECS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] Have you followed the guidelines in our Contributing document?
Yes.
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
Yes; none open implementing --non-interactive and --timeout-wait-for-user handling for prompts.
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
Yes; PR description explains prompt detection, timeout, non-interactive sudo, skip reporting, and motivation referencing #20338.
[x] Have you written new tests for your changes?
This change hooks into SystemCommand and command plumbing; core suite passes. Follow-up targeted specs can be added for prompt-detection/timeout behavior if requested.
[x] Have you successfully run brew style with your changes locally?
Yes; no offenses.
[x] Have you successfully run brew typecheck with your changes locally?
Yes; “No errors! Great job.”
[x] Have you successfully run brew tests with your changes locally?
Yes; tests pass with only expected pending cases unrelated to this change.
Status update:
Confirmed style, typecheck, and tests pass locally; verified no conflicting PRs; PR description includes full motivation and design; ready to submit.